Skip to content

Update ERC-7754: updating the acronym to avoid negative connotation#991

Merged
eip-review-bot merged 4 commits intoethereum:masterfrom
uni-guillaume:master
Aug 5, 2025
Merged

Update ERC-7754: updating the acronym to avoid negative connotation#991
eip-review-bot merged 4 commits intoethereum:masterfrom
uni-guillaume:master

Conversation

@uni-guillaume
Copy link
Contributor

@uni-guillaume uni-guillaume commented Mar 24, 2025 •
edited
Loading

updating the acronym to avoid negative connotation.
see https://www.urbandictionary.com/define.php?term=twit

adding key security detail to the wallet verification spec

@uni-guillaume
ERC-7754: updating the acronym to avoid negative connotation
f4e8302 
Signed-off-by: Guillaume Grosbois <guillaume.grosbois@uniswap.org>
@eip-review-bot
Copy link
Collaborator

eip-review-bot commented Mar 24, 2025 •
edited
Loading

✅ All reviewers have approved.

@eip-review-bot eip-review-bot changed the title ERC-7754: updating the acronym to avoid negative connotation Update ERC-7754: updating the acronym to avoid negative connotation Mar 24, 2025
@eip-review-bot eip-review-bot enabled auto-merge (squash) March 24, 2025 17:23
eip-review-bot
eip-review-bot approved these changes Mar 24, 2025
View reviewed changes
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@github-actions github-actions bot added the w-ci label Mar 24, 2025
eip-review-bot
eip-review-bot approved these changes Mar 24, 2025
View reviewed changes
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@poojaranjan poojaranjan mentioned this pull request Jun 6, 2025
Closed
53 tasks
SamWilsn
SamWilsn reviewed Jun 10, 2025
View reviewed changes
ERCS/erc-7754.md Outdated
---
eip: 7754
title: Tamperproof Web Immutable Transaction (TWIT)
title: Tamperproof Web Immutable Secure Transaction (TWIST)
Copy link
Contributor

@SamWilsn SamWilsn Jun 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really see a way to reduce the title except moving the expanded form to the abstract.

Suggested change
title: Tamperproof Web Immutable Secure Transaction (TWIST)
title: Tamperproof Extension Wallets API (TWIST)

Copy link
Contributor Author

@uni-guillaume uni-guillaume Jul 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

accepted your suggestion

eip-review-bot
eip-review-bot approved these changes Jun 10, 2025
View reviewed changes
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

eip-review-bot
eip-review-bot previously approved these changes Jul 23, 2025
View reviewed changes
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@github-actions
Copy link

github-actions bot commented Jul 23, 2025

The commit 9857889 (as a parent of 66aea0e) contains errors.
Please inspect the Run Summary for details.

auto-merge was automatically disabled July 23, 2025 23:10

Head branch was pushed to by a user without write access

@eip-review-bot eip-review-bot enabled auto-merge (squash) July 23, 2025 23:11
eip-review-bot
eip-review-bot previously approved these changes Jul 23, 2025
View reviewed changes
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

auto-merge was automatically disabled July 23, 2025 23:12

Head branch was pushed to by a user without write access

@uni-guillaume
ERC-7754: adding key security detail to the TWIST verification spec
fbe06ff 
Signed-off-by: Guillaume Grosbois <guillaume.grosbois@uniswap.org>
@eip-review-bot eip-review-bot enabled auto-merge (squash) July 23, 2025 23:13
eip-review-bot
eip-review-bot approved these changes Jul 23, 2025
View reviewed changes
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

eip-review-bot
eip-review-bot previously approved these changes Jul 23, 2025
View reviewed changes
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@uni-guillaume
ERC-7754: shortening the title
3bb198d 
Signed-off-by: Guillaume Grosbois <guillaume.grosbois@uniswap.org>
auto-merge was automatically disabled July 23, 2025 23:16

Head branch was pushed to by a user without write access

@eip-review-bot eip-review-bot enabled auto-merge (squash) July 23, 2025 23:17
eip-review-bot
eip-review-bot approved these changes Jul 23, 2025
View reviewed changes
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

eip-review-bot
eip-review-bot approved these changes Jul 23, 2025
View reviewed changes
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@github-actions github-actions bot removed the w-ci label Jul 23, 2025
eip-review-bot
eip-review-bot approved these changes Jul 23, 2025
View reviewed changes
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@poojaranjan poojaranjan mentioned this pull request Jul 22, 2025
Closed
@poojaranjan poojaranjan mentioned this pull request Aug 5, 2025
Closed
3 tasks
@SamWilsn SamWilsn closed this Aug 5, 2025
auto-merge was automatically disabled August 5, 2025 16:46

Pull request was closed

@SamWilsn SamWilsn reopened this Aug 5, 2025
@eip-review-bot eip-review-bot enabled auto-merge (squash) August 5, 2025 16:47
eip-review-bot
eip-review-bot approved these changes Aug 5, 2025
View reviewed changes
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eip-review-bot eip-review-bot merged commit 5aa20fd into ethereum:master Aug 5, 2025
19 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SamWilsn SamWilsn SamWilsn left review comments

@eip-review-bot eip-review-bot eip-review-bot approved these changes

+1 more reviewer

@hodl4fun hodl4fun hodl4fun approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c-update s-draft t-erc

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@uni-guillaume @eip-review-bot @SamWilsn @hodl4fun